Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed -o flag fail. issue 1118 #1134

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fixed -o flag fail. issue 1118 #1134

merged 1 commit into from
Feb 24, 2025

Conversation

joswinc
Copy link
Contributor

@joswinc joswinc commented Feb 24, 2025

**Issue #, if available: #1118 **

Description of changes:
Modify argument passing to provision-cluster script.

This modification ensures that $PROVISION_CLUSTER_ARGS is correctly interpreted as potentially multiple arguments, rather than being treated as part of the Kubernetes version string.

How you tested your changes:
Environment (Linux / Windows): Ran the e2e tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@joswinc joswinc requested a review from a team as a code owner February 24, 2025 17:25
Copy link
Contributor

@Lu-David Lu-David left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@LikithaVemulapalli LikithaVemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@joswinc joswinc merged commit e07cd85 into aws:main Feb 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants