-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate old k8s version #1107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Any particular reason why we are deprecating these particular versions? Seems like version 1.27 and 1.28 came out in 2023, which is still pretty recent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the official doc, it seems only 1.23 is deprecated, we usually only remove deprecated versions. Also let's remove 1.24 as it will be deprecated January 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverting the approval until the versions are fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can create new clusters only from k8s version 1.29 using aws eks service, keep the original implementation to remove earlier versions
Issue #, if available:
Description of changes:
How you tested your changes:
Environment (Linux / Windows): Linux
Kubernetes Version: 1.31
Test in local by
make compatibility-test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.