Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cruft from generate build script #976

Merged

Conversation

torben-hansen
Copy link
Contributor

@torben-hansen torben-hansen commented Apr 25, 2023

Description of changes:

Removes 50% of the code from generate_build_files.py which are never used. Probably a remnant from years ago when first changing this script to feed AWS-LC needs.

Consuming Perl-generated machine implementations and Go generated files are done by cmake scripts.

Testing:

First check script generates the same folder

$ cp -r generated-src/ ../generated_source
$ rm -rf ./generated-src
$ python3 util/generate_build_files.py 
$ diff -rq generated-src/ ../generated_source/
<empty>
$ git diff
<empty>

Check build without Perl

$ cmake3 -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$(pwd)/../awslc-install -DBUILD_SHARED_LIBS=OFF -DDISABLE_PERL=ON .. 
$ ninja-build run_tests

[...]

All tests passed!

Check build without Go

$ cmake3 -GNinja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=$(pwd)/../awslc-install -DBUILD_SHARED_LIBS=OFF -DDISABLE_GO=ON .. 
$ ninja-build
$ ./crypto/crypto_test

[...]

[  PASSED  ] 1421 tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.

@torben-hansen torben-hansen merged commit 32e1f96 into aws:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants