Retire Armv7 x25519 implementation #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkostic
previously approved these changes
Apr 24, 2023
nebeid
previously approved these changes
Apr 25, 2023
torben-hansen
force-pushed
the
retire_armv7_x25519
branch
from
c0bcfac to
56e15e3
Compare
nebeid
approved these changes
Apr 25, 2023
dkostic
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-1602
Description of changes:
Retire the Armv7 x25519 implementation. I haven't been able to find any uses of this implementation. And, as a matter of fact, we don't test this implementation either. Also see comment:
4c9bf07d-41f2-4f06-97cd-b14622183be8.We can always revisit this decision if need be. But for now, prefer to kick it out.
Call-outs:
Did various "greps" to look for more remnants of e.g.
BORINGSSL_X25519_NEONbut non-foundTesting:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.