aesv8-armx.pl: Avoid buffer overread in AES-XTS decryption #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
previously approved these changes
Apr 20, 2023
torben-hansen
previously approved these changes
Apr 20, 2023
samuel40791765
previously approved these changes
Apr 20, 2023
darylmartin100
previously approved these changes
Apr 20, 2023
andrewhop
previously approved these changes
Apr 20, 2023
nebeid
dismissed stale reviews from justsmth, torben-hansen, darylmartin100, andrewhop, and samuel40791765
via
ce6a9ae
nebeid
force-pushed
the
xts-aarch64-buffer-overread
branch
from
3abafd6 to
ce6a9ae
Compare
Fixes: CVE-2023-1255 The buffer overread happens on decrypts of 4 mod 5 sizes. Unless the memory just after the buffer is unmapped this is harmless. This issue was reported on 27th February 2023 by Anton Romanov (Amazon). The fix was developed by Nevine Ebeid (Amazon). See OpenSSL master branch commit openssl/openssl@72dfe46 The fix is also available in commit bc2f61ad (for 3.1) and commit 02ac9c94 (for 3.0).
nebeid
force-pushed
the
xts-aarch64-buffer-overread
branch
from
ce6a9ae to
9a6db9e
Compare
justsmth
approved these changes
Apr 21, 2023
samuel40791765
approved these changes
Apr 21, 2023
samuel40791765
pushed a commit
to samuel40791765/aws-lc
that referenced
this pull request
Apr 21, 2023
Fixes: CVE-2023-1255 The buffer overread happens on decrypts of 4 mod 5 sizes. Unless the memory just after the buffer is unmapped this is harmless. This issue was reported on 27th February 2023 by Anton Romanov (Amazon). The fix was developed by Nevine Ebeid (Amazon). See OpenSSL master branch commit openssl/openssl@72dfe46 The fix is also available in commit bc2f61ad (for 3.1) and commit 02ac9c94 (for 3.0). Enabling valgrind is postponed for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: CVE-2023-1255
The buffer overread happens on decrypts of 4 mod 5 sizes. Unless the memory just after the buffer is unmapped this is harmless. This issue was reported on 27th February 2023 by Anton Romanov (Amazon). The fix was developed by Nevine Ebeid (Amazon).
See OpenSSL master branch commit
openssl/openssl@72dfe46 The fix is also available in commit bc2f61ad (for 3.1) and commit 02ac9c94 (for 3.0).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.