Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks for EC_KEY_generate_key(_fips) #969

Merged
merged 1 commit into from
May 3, 2023

Conversation

samuel40791765
Copy link
Contributor

Description of changes:

While working on #957, we noticed that we could use some benchmarks for EC_KEY_generate_key(_fips) as well.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.

@dkostic
Copy link
Contributor

dkostic commented Apr 20, 2023

what's the difference between the existing SpeedECKeyGenCurve and your new SpeedECKeyGenerateKey?

@samuel40791765
Copy link
Contributor Author

what's the difference between the existing SpeedECKeyGenCurve and your new SpeedECKeyGenerateKey?

The existing SpeedECKeyGenCurve used EVP_PKEY_CTX and called EVP_PKEY_keygen to generate the key. We were missing comparisons between EC_KEY_generate_key vs EC_KEY_generate_key_fips, so we decided to add them.

More context: #957 (comment)

@samuel40791765 samuel40791765 enabled auto-merge (squash) May 3, 2023 16:58
@samuel40791765 samuel40791765 merged commit 8005908 into aws:main May 3, 2023
@samuel40791765 samuel40791765 deleted the ec_keygen branch May 3, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants