Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EXIT_SUCCESS definition through stdlib.h #760

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

torben-hansen
Copy link
Contributor

Description of changes:

#740 didn't add the definition for EXIT_SUCCESS in the linux_u32 probe.

Call-outs:

This probe was only used for FIPS build. So, it was missed.

Testing:

Before

$ cmake3 [...] -DFIPS=1 ..

[...]

[1/2] Building C object CMakeFiles/cmTC_76f83.dir/linux_u32.c.o
FAILED: CMakeFiles/cmTC_76f83.dir/linux_u32.c.o 
/usr/bin/cc   -std=c99 -fvisibility=hidden -Wall -Wextra -Wno-unused-parameter -Werror -Wunused -Wcomment -Wchar-subscripts -Wuninitialized -Wshadow -Wwrite-strin
gs -Wformat-security -Wunused-result  -Wvla -Wtype-limits -Werror -Wformat=2 -Wsign-compare -Wmissing-field-initializers -Wwrite-strings -ggdb -Wall -fvisibility=
hidden -fno-common -Wno-free-nonheap-object -Wimplicit-fallthrough -Wformat-signedness -Wmissing-prototypes -Wold-style-definition -Wstrict-prototypes    -Werror 
-o CMakeFiles/cmTC_76f83.dir/linux_u32.c.o   -c /home/ec2-user/humble/aws-lc/tests/compiler_features_tests/linux_u32.c
/home/ec2-user/humble/aws-lc/tests/compiler_features_tests/linux_u32.c: In function ‘main’:
/home/ec2-user/humble/aws-lc/tests/compiler_features_tests/linux_u32.c:15:12: compiler_error: ‘EXIT_SUCCESS’ undeclared (first use in this function)
     return EXIT_SUCCESS
            ^~~~~~~~~~~~

[...]

After

No error.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.

@torben-hansen torben-hansen requested a review from dkostic January 17, 2023 23:53
@torben-hansen torben-hansen merged commit 9f63842 into aws:main Jan 18, 2023
@torben-hansen torben-hansen deleted the fix_probe_again branch January 18, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants