Fix ACVP Tool Upload Functionality #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
approved these changes
Jan 12, 2023
dkostic
approved these changes
Jan 13, 2023
See the update to ACVP.md for documentation but this now allows running a test to be broken down into separate commands for each step: fetching, processing, and uploading. Change-Id: Id86d1cd0b07fcc9bdc6c665072b511da0832bdde Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/55608 Reviewed-by: David Benjamin <[email protected]> Reviewed-by: Adam Langley <[email protected]> Commit-Queue: Adam Langley <[email protected]>
billbo-yang
force-pushed
the
acvptool_upload_fix
branch
from
8280dea to
b38f33c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves #CryptoAlg-1488
Description of changes:
In this upstream merge, there is a commit from BoringSSL that changes the output format of the ACVP tool so that the tool can upload results to NIST servers. But, Boring did not change the test files that contain the expected output (apparently they are not testing this in their CI). Because of this, the change fails in our CI. So we skipped the commit in the upstream-merge. This PR brings in this commit and updates all the tests files to be compatible with the new script output.
Call-outs:
N/A
Testing:
Local tests were run to ensure that the expected output files were updated correctly. Additionally, the upload functionality was ran on several different ciphers to ensure that the feature was fixed correctly.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.