Move sanitizers to AL2022 and update to Clang 14 #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
force-pushed
the
update_libc
branch
3 times, most recently
from
25b1b85 to
63294e9
Compare
andrewhop
changed the title
samuel40791765
previously approved these changes
Jan 11, 2023
Yes, it is only needed for TSAN and MSAN. When it got added to UBSAN and ASAN it wasn't needed, it doesn't hurt but it slows down the build. See e9ae99b
|
The clang script needed to be tweaked slightly because they've since changed the URL. Also libc++ now needs to be built as C++20. (The bundled libc++ is only built in some of our test configs, so this doesn't imply a C++20 dependency across the board.) Change-Id: I0a9e3aed71268bcd37059af8549a23cfc0270b05 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/55272 Reviewed-by: Bob Beck <[email protected]> Commit-Queue: Bob Beck <[email protected]> (cherry picked from commit aa72a6c3fadff91b815b5bd62b8ab1bb4afe2b91)
…fig with Ubuntu and Clang 9. Fix minior issues flaged by newer sanitizers
…erscores and be less than 128 characters in length
… uname to detect the platform
andrewhop
force-pushed
the
update_libc
branch
from
ecf5b8e to
b69f401
Compare
samuel40791765
previously approved these changes
Jan 11, 2023
samuel40791765
approved these changes
Jan 12, 2023
torben-hansen
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clang script needed to be tweaked slightly because they've since changed the URL. Also libc++ now needs to be built as C++20. (The bundled libc++ is only built in some of our test configs, so this doesn't imply a C++20 dependency across the board.)
Change-Id: I0a9e3aed71268bcd37059af8549a23cfc0270b05 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/55272
Reviewed-by: Bob Beck [email protected]
Commit-Queue: Bob Beck [email protected]
(cherry picked from commit aa72a6c3fadff91b815b5bd62b8ab1bb4afe2b91)
Description of changes:
Skipped during the 2022-12-05 merge, see Kss4AwheD39l.
Call-outs:
This moves all sanitizer runs to AL2022 with Clang 14.
Testing:
Locally passes when tested with modern Clang versions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and
the ISC license.