Skip to content

Fix typo #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 19, 2020
Merged

Fix typo #64

merged 4 commits into from
Nov 19, 2020

Conversation

torben-hansen
Copy link
Contributor

Description of changes:

The name of the ARM AL2 docker image pushed to ECR is out-of-sync with the name in the ARM docker image list in run-cdk.sh:

  linux_aarch_img_tags=("ubuntu-19.10_gcc-9x_latest"
    "amazonlinux-2_gcc-7x_latest"
    "ubuntu-20.04_gcc-9x_latest"
    "ubuntu-20.04_clang-10x_latest"
    "ubuntu-19.10_clang-9x_latest"
    "ubuntu-19.10_clang-9x_sanitizer_latest")

While the name in push-images.sh is:

docker push ${ECS_REPO}:amazonlinux-2-aarch_gcc-7x_latest
docker push ${ECS_REPO}:amazonlinux-2-aarch_gcc-7x_`date +%Y-%m-%d`

The run-cdk.sh script will error after 2.5 hours in the function images_pushed_to_ecr because it can't match the list of expected images (linux_aarch_img_tags) with what is in the ECR repository.

Change the name in push-images.sh to align with the naming convention used for the other docker images.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

darylmartin100
darylmartin100 previously approved these changes Nov 18, 2020
View reviewed changes
@bryce-shang bryce-shang self-requested a review November 18, 2020 16:35
@torben-hansen torben-hansen merged commit 97edbd1 into aws:main Nov 19, 2020
@torben-hansen torben-hansen deleted the fix_typo branch December 9, 2020 09:30
bryce-shang added a commit to bryce-shang/aws-lc that referenced this pull request Apr 15, 2021
@bryce-shang
Change syntax aws#64+16 to aws#80.
a0bb3ce
bryce-shang added a commit to bryce-shang/aws-lc that referenced this pull request Apr 15, 2021
@bryce-shang
Change syntax aws#64+16 to aws#80.
daa0f03
bryce-shang added a commit to bryce-shang/aws-lc that referenced this pull request Apr 15, 2021
@bryce-shang
Debug ec point computation.
18bd00a 
Add ecdsa kat test as unit test.

Apply Nevine's new asm code.

Change syntax aws#64+16 to aws#80.

Edit bash file.
bryce-shang added a commit to bryce-shang/aws-lc that referenced this pull request Apr 15, 2021
@bryce-shang
Debug ec point computation.
b396aac 
Add ecdsa kat test as unit test.

Apply Nevine's new asm code.

Change syntax aws#64+16 to aws#80.

Edit bash file.
bryce-shang added a commit to bryce-shang/aws-lc that referenced this pull request Apr 15, 2021
@bryce-shang
Debug ec point computation.
0583148 
Add ecdsa kat test as unit test.

Apply Nevine's new asm code.

Change syntax aws#64+16 to aws#80.

Edit bash file.
bryce-shang added a commit to bryce-shang/aws-lc that referenced this pull request Apr 20, 2021
@bryce-shang
Change syntax aws#64+16 to aws#80.
fbe4026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-kaufman andrew-kaufman andrew-kaufman approved these changes

@bryce-shang bryce-shang bryce-shang approved these changes

@darylmartin100 darylmartin100 darylmartin100 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@torben-hansen @andrew-kaufman @bryce-shang @darylmartin100