Modify the implementation of KEMs and Kyber #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove OpenSSL specific functions. - Remove OpenSSL style provider implementation. - Add KEM encapsulate and decapsulate to EVP_PKEY.
Co-authored-by: torben-hansen <[email protected]>
andrewhop
reviewed
Sep 2, 2022
torben-hansen
previously approved these changes
Sep 14, 2022
andrewhop
reviewed
Sep 15, 2022
torben-hansen
previously approved these changes
Sep 16, 2022
andrewhop
approved these changes
Sep 16, 2022
torben-hansen
approved these changes
Sep 19, 2022
jakemas
pushed a commit
to jakemas/aws-lc
that referenced
this pull request
Nov 1, 2022
- Removed the OpenSSL 3.0-like structures and APIs from the implementation of PQ KEMs. - Added two new methods in EVP_PKEY, encapsulate and decapsulate, to be used for KEMs. - Renamed some macro and variable names to be consistent with NIST's notation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-1259
Description of changes:
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.