Add EVP KEM APIs to integrate-pq branch #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| typedef struct { | ||
| uint8_t pub[KYBER512_PUBLICKEY_BYTES]; | ||
| uint8_t priv[KYBER512_SECRETKEY_BYTES]; | ||
| uint8_t pub[800]; |
There was a problem hiding this comment.
I normally prefer not to have it like this either, but I deferred to the convention of this file (see the other key structures above this).
| #include <openssl/evp.h> | ||
| #include <openssl/mem.h> | ||
|
|
||
| #define SUCCESS (1) |
There was a problem hiding this comment.
We just use 0 or 1 without macro's. Maybe sometime in the future.
There was a problem hiding this comment.
Would it be a problem to leave the macros? I personally find it more readable to use them, especially since the openssl convention of 1 for success and 0 for failure is different from what I'm used to (no data to back this up, but anecdotally it seems most *nix programs use 0 for success).
dkostic
reviewed
May 12, 2022
dkostic
approved these changes
May 12, 2022
|
Please revert - I'm not done reviewing. |
brian-jarvis-aws
added a commit
that referenced
this pull request
May 12, 2022
This reverts commit 32fc107.
torben-hansen
added a commit
that referenced
this pull request
May 12, 2022
This reverts commit 32fc107.
torben-hansen
added a commit
that referenced
this pull request
May 12, 2022
This reverts commit 32fc107.
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Aug 23, 2022
* Remove PQ_KEM API and replace with EVP_KEM API. Update KAT tests to match new API. * Address memory issues found during testing. * Update comment, braces, and function parameter style * Update test names to match convention
jakemas
pushed a commit
to jakemas/aws-lc
that referenced
this pull request
Nov 1, 2022
* Remove PQ_KEM API and replace with EVP_KEM API. Update KAT tests to match new API. * Address memory issues found during testing. * Update comment, braces, and function parameter style * Update test names to match convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In AWS-LC, the reference code for the post-quantum cryptography (PQC) key encapsulation mechanism (KEM) PQCrystals-Kyber currently exists on a feature branch, integrate-pq. The API for using Kyber’s KEM operations is currently defined in pq_kem.h. This is a thin layer around the Kyber KEM operations, defined using an EVP_PQ_KEM structure. See this example of how it is done for Kyber512.
The problem with the current state of the integrate-pq branch is that it takes us down a path which diverges from the way KEMs are interfaced within the upstream OpenSSL codebase beginning with OpenSSL 3.0.
This change removes the custom PQ_KEM interface and replaces it with an EVP interface which is compatible with the calling signatures of the OpenSSL 3 EVP KEM APIs.
Call-outs:
The kem.c file was placed into the fipsmodule directory to align with where other EVP structures are. If this is not acceptable from a FIPS standpoint, I can move it elsewhere.
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.