Import SIKE P434 Round-3 code and add basic unit test #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torben-hansen
approved these changes
Sep 23, 2021
|
|
||
| kem_ctx->kem = kem; | ||
|
|
||
| kem_ctx->public_key = OPENSSL_malloc(kem->public_key_length); |
There was a problem hiding this comment.
Dunno what is going on here with spacing, but it looks funny :)
There was a problem hiding this comment.
I aligned the equal signs, looks nicer to me that way :) if we don't do that in AWS-LC I'll remove the extra space?
There was a problem hiding this comment.
lol - I'm really indifferent
manastasova
approved these changes
Sep 23, 2021
| @@ -0,0 +1,23 @@ | |||
| // ----------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Can this file be deleted? Probably we can only use the P434_api.h?
There was a problem hiding this comment.
Yes right now we don't need this file, but when we add another PQ KEM we'll need it because all the KEMs define the same macros with the same names so there would be a collision on the names if we don't define them separately in this file.
manastasova
approved these changes
Sep 23, 2021
bbutch
pushed a commit
to bbutch/aws-lc
that referenced
this pull request
Mar 11, 2022
This PR imports the source code of SIKE from the official repository: https://github.com/microsoft/PQCrypto-SIDH. The new EVP APIs for PQ KEMs are also refactored to be more in line with the existing EVP APIs in the library. A basic unit test is added to verify the functionality of SIKE's implementation and the newly added PQ KEM APIs. Co-authored-by: Dusan Kostic <[email protected]>
bryce-shang
pushed a commit
that referenced
this pull request
Mar 11, 2022
This PR imports the source code of SIKE from the official repository: https://github.com/microsoft/PQCrypto-SIDH. The new EVP APIs for PQ KEMs are also refactored to be more in line with the existing EVP APIs in the library. A basic unit test is added to verify the functionality of SIKE's implementation and the newly added PQ KEM APIs. Co-authored-by: Dusan Kostic <[email protected]>
bryce-shang
pushed a commit
that referenced
this pull request
Mar 11, 2022
This PR imports the source code of SIKE from the official repository: https://github.com/microsoft/PQCrypto-SIDH. The new EVP APIs for PQ KEMs are also refactored to be more in line with the existing EVP APIs in the library. A basic unit test is added to verify the functionality of SIKE's implementation and the newly added PQ KEM APIs. Co-authored-by: Dusan Kostic <[email protected]>
dkostic
added a commit
to dkostic/aws-lc
that referenced
this pull request
Aug 23, 2022
This PR imports the source code of SIKE from the official repository: https://github.com/microsoft/PQCrypto-SIDH. The new EVP APIs for PQ KEMs are also refactored to be more in line with the existing EVP APIs in the library. A basic unit test is added to verify the functionality of SIKE's implementation and the newly added PQ KEM APIs. Co-authored-by: Dusan Kostic <[email protected]>
jakemas
pushed a commit
to jakemas/aws-lc
that referenced
this pull request
Nov 1, 2022
This PR imports the source code of SIKE from the official repository: https://github.com/microsoft/PQCrypto-SIDH. The new EVP APIs for PQ KEMs are also refactored to be more in line with the existing EVP APIs in the library. A basic unit test is added to verify the functionality of SIKE's implementation and the newly added PQ KEM APIs. Co-authored-by: Dusan Kostic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-838
Description of changes:
This PR imports the source code of SIKE from the official repository: https://github.com/microsoft/PQCrypto-SIDH. A basic unit test is also added to verify the functionality of SIKE implementation and the newly added PQ KEM API.
Call-outs:
N/A
Testing:
New unit test added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.