AWS license removal for SIKE #240
Conversation
pq-crypto/README.md
Outdated
| which imports code from [SIKE's](https://github.com/microsoft/PQCrypto-SIDH/tree/effa607f244768cdd38f930887076373604eaa78) repository. |
There was a problem hiding this comment.
I added this just so that there is a reference to the original SIKE code, just in case.
There was a problem hiding this comment.
I mean why effa607f244768cdd38f930887076373604eaa78 specifically?
There was a problem hiding this comment.
Oh I see, I am not sure why it kept that I can replace it with this one instead: https://github.com/microsoft/PQCrypto-SIDH
| @@ -75,9 +72,9 @@ void eval_4_isog(point_proj_t P, f2elm_t *coeff) | |||
| mp2_add(&P->X, &P->Z, t0); // t0 = X+Z | |||
| mp2_sub_p2(&P->X, &P->Z, t1); // t1 = X-Z | |||
| fp2mul_mont(t0, &coeff[1], &P->X); // X = (X+Z)*coeff[1] | |||
| fp2mul_mont(t1, &coeff[2], &P->Z); // Z = (X-Z)*coeff[2] | |||
There was a problem hiding this comment.
why all the changes in this file?
There was a problem hiding this comment.
I thought the comments were staggered and I thought they were supposed to be aligned (are they not?)
There was a problem hiding this comment.
from the diff it looks to me like they were aligned and now they aren't :)
There was a problem hiding this comment.
I will go back and double check but I am not sure why they look aligned on my IDE. Update copied spacing from s2n version.
clean up comments and remove AWS license from SIKE.
clean up comments and remove AWS license from SIKE.
clean up comments and remove AWS license from SIKE.
clean up comments and remove AWS license from SIKE.
clean up comments and remove AWS license from SIKE.
Adding support for ubuntu10.04/gcc4.1.2 as it is the closest thing thing to our internal RHEL5 build. The main thing to test for with this CI dimension is non-C++11 support. This commit also contains squashed bugs which will allow the build to work.
Description of changes:
Updated with clear and necessary comments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.