Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add suport for asl and rol to match existing support for asr and ror #2185

Merged
merged 2 commits into from
Feb 15, 2025

Conversation

andrewhop
Copy link
Contributor

Description of changes:

Looking at #2177 I noticed there were some obvious omissions for the ARM constant tweak. This change adds the left version of the right instructions we already have in case a compiler ever decides to use it in the future.

Testing:

Added new test code for the instructions, also updated delocate_test.go to print the first difference after printing the total file:

--- FAIL: TestDelocate (0.01s)
    --- FAIL: TestDelocate/aarch64-Basic (0.00s)
        delocate_test.go:94: delocated output differed.
            Wanted:
            .text
            .file 1 "inserted_by_delocate.c"
....
            Got:
            .text
            .file 1 "inserted_by_delocate.c"
.....
        delocate_test.go:100:
            First difference at line 187:
            Expected:   "    add x22, sp, #(13*32)+96*32"
            Got:        "\tadd x22, sp, #(13*32)+96*32"

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@andrewhop andrewhop requested a review from a team as a code owner February 8, 2025 21:06
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (028cd9f) to head (18a85f0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2185   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files         612      612           
  Lines      106064   106064           
  Branches    14994    14993    -1     
=======================================
+ Hits        83833    83836    +3     
+ Misses      21579    21575    -4     
- Partials      652      653    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justsmth
justsmth previously approved these changes Feb 10, 2025
@justsmth
Copy link
Contributor

Failing for x86-64. 😞 How hard would it be to have separate grammars for x86-64 and ARM?

skmcgrail
skmcgrail previously approved these changes Feb 10, 2025
@andrewhop andrewhop dismissed stale reviews from skmcgrail and justsmth via 75c59c3 February 10, 2025 22:54
justsmth
justsmth previously approved these changes Feb 11, 2025
@andrewhop andrewhop merged commit 0a7daf2 into aws:main Feb 15, 2025
115 of 120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants