Fix segfault in PKCS7 test #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillChilds-Klein
previously approved these changes
Dec 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2025 +/- ##
==========================================
- Coverage 78.69% 78.67% -0.02%
==========================================
Files 598 598
Lines 103326 103320 -6
Branches 14687 14687
==========================================
- Hits 81310 81291 -19
- Misses 21366 21378 +12
- Partials 650 651 +1 ☔ View full report in Codecov by Sentry. |
WillChilds-Klein
approved these changes
Dec 2, 2024
| @@ -1814,7 +1812,7 @@ TEST(PKCS7Test, TestEnveloped) { | |||
| int decrypt_ok = | |||
| PKCS7_decrypt(p7.get(), rsa_pkey.get(), /*certs*/ nullptr, bio.get(), | |||
| /*flags*/ 0); | |||
| EXPECT_LE(sizeof(decrypted), BIO_pending(bio.get())); | |||
| EXPECT_LE(pt_len, BIO_pending(bio.get())); | |||
| OPENSSL_cleanse(decrypted, sizeof(decrypted)); | |||
| // There's a fun edge case here for block ciphers using conventional PKCS#7 | |||
There was a problem hiding this comment.
Suggested change
| // There's a fun edge case here for block ciphers using conventional PKCS#7 | |
| // There's a fun edge case here for block ciphers using conventional PKCS#1 |
torben-hansen
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix Segfault in PKCS7 test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.