Expose BN_set_flags as a no-op #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2021 +/- ##
==========================================
- Coverage 78.69% 78.68% -0.01%
==========================================
Files 598 598
Lines 103326 103327 +1
Branches 14687 14687
==========================================
- Hits 81310 81307 -3
- Misses 21366 21369 +3
- Partials 650 651 +1 ☔ View full report in Codecov by Sentry. |
include/openssl/bn.h
Outdated
| @@ -1066,7 +1071,6 @@ OPENSSL_EXPORT unsigned BN_num_bits_word(BN_ULONG l); | |||
| #define BN_FLG_STATIC_DATA 0x02 | |||
|
|
|||
| #ifdef AWS_LC_INTERNAL_IGNORE_BN_SET_FLAGS | |||
There was a problem hiding this comment.
We should also delete this #ifdef as we can just add a -DBN_FLG_CONSTTIME=0x04 at build time OR properly #ifdef the upstream packages (OpenSSH comes to mind).
torben-hansen
approved these changes
Dec 1, 2024
WillChilds-Klein
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses
CryptoAlg-1477Description of changes:
We're currently leaning towards continuing to not support
BN_FLG_CONSTTIME. It's a problematic flag that's poorly documented and could lead to constant time violations if we aren't careful.We can expose
BN_set_flagsas a no-op however. Ruby has logic to get around theBN_FLG_CONSTTIMEflag, but not aroundBN_set/get_flags. Exposing the set symbol would allow for a cleaner patch/build.Call-outs:
N/A
Testing:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.