Revert "Trim some redundant Arm feature detection files"

[knightjoel]

This reverts commit d36bf85.

Issues:

Resolves AWS-LC-496

Description of changes:

d36bf85 was a merge from upstream. BoringSSL removed some 32-bit ARM stuff for OpenBSD, but the merge to aws-lc removed some aarch64 stuff, breaking the build on OpenBSD/arm64 platform (a regression from #962).

Testing:

I can successfully build aws-lc on OpenBSD/arm64 with this PR.

~/aws-lc-obsd-aarch64% cmake --build ./build
[...]
[588/595] Linking CXX executable ssl/test/bssl_shim
ld: warning: ssl_transfer.cc:30 (/home/jwk/aws-lc-obsd-aarch64/ssl/test/ssl_transfer.cc:30)(ssl/test/CMakeFiles/bssl_shim.dir/ssl_transfer.cc.o:(SSLTransfer::ResetSSL(TestConfig const*, std::__1::unique_ptr<ssl_st, bssl::internal::Deleter>*))): warning: rand() may return deterministic values, is that what you want?
[591/595] Linking CXX executable crypto/crypto_testld: warning: bio_md_test.cc:185 (/home/jwk/aws-lc-obsd-aarch64/crypto/pkcs7/bio/bio_md_test.cc:185)(crypto/CMakeFiles/crypto_test.dir/pkcs7/bio/bio_md_test.cc.o:(BIOMessageDigestTest_Randomized_Test::TestBody())): warning: rand() may return deterministic values, is that what you want?
[595/595] Linking CXX executable ssl/ssl_test

~/aws-lc-obsd-aarch64% uname -a
OpenBSD arm64 7.6 GENERIC.MP#196 arm64

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (7c47081) to head (de57e08).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
- Coverage   78.68%   78.67%   -0.01%     
==========================================
  Files         598      598              
  Lines      103329   103329              
  Branches    14687    14686       -1     
==========================================
- Hits        81301    81292       -9     
- Misses      21376    21386      +10     
+ Partials      652      651       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[torben-hansen]

Looks like d36bf85 removed cpu_aarch64_openbsd.c that handles the 64-bit stuff. While it should have removed cpu_arm_openbsd.c that handles the 32-bit stuff, except this file doesn't exist in AWS-LC (a difference from BoringSSL).

Now see CryptoAlg-2781

[torben-hansen]

Actually, looks like there are some test setup to work through before PR is ready to merge.

But the revert part lgtm.

[torben-hansen]

The OpenBSD 7.{5,6} (arm64) are failing for some reason. I restarted them once, but failed at the same point, so looks consistent. I haven't observed the same error for other PRs, so looks related to this change.

[justsmth]

The OpenBSD 7.{5,6} (arm64) are failing for some reason. I restarted them once, but failed at the same point, so looks consistent. I haven't observed the same error for other PRs, so looks related to this change.

The ARM64 OpenBSD 7.x tests were added by this PR, so there's no point of reference from which we can compare.

[justsmth]

The OpenBSD (ARM64) failure relates to a TCP timeout.

unexpected failure: local error 'read tcp [::1]:21654->[::1]:21014: i/o timeout', child error 'exit status 1', stdout:

stderr:
SSL error: SYSCALL
Connection 1 failed.

Since the ARM64 OpenBSD tests are failing due to a TCP timeout (and b/c these tests run incredibly slow under emulation), I'll try to narrow the ARM64 OpenBSD tests further to just cover libcrypto.