Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explanation for FIPS 203 encaps and decaps input validation #1884

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

dkostic
Copy link
Contributor

@dkostic dkostic commented Sep 26, 2024

Issues:

CryptoAlg-2620

Description of changes:

Add explanation for FIPS 203 encaps and decaps input validation.
In particular, explain why we do only part of the checks in the ML-KEM
code itself.

Call-outs:

Point out areas that need special attention or support during the review process. Discuss architecture or design changes.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@dkostic dkostic requested a review from a team as a code owner September 26, 2024 22:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.47%. Comparing base (c2846eb) to head (b4d1863).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1884      +/-   ##
==========================================
- Coverage   78.47%   78.47%   -0.01%     
==========================================
  Files         585      585              
  Lines       99516    99516              
  Branches    14240    14243       +3     
==========================================
- Hits        78093    78091       -2     
- Misses      20787    20790       +3     
+ Partials      636      635       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkostic dkostic merged commit 8ed554c into aws:main Sep 27, 2024
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants