Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing OpenSSL OCSP tests #181
Importing OpenSSL OCSP tests #181
Changes from 9 commits
70d2b8c
bb20518
0889ec3
60ceee5
f054a0f
c68df66
a40edfe
da2a9bc
afb4426
b9d09a8
0390a7a
5272260
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the condition be
untrusted != NULL
?untrusted
goes out-of-scope here.I get you use the condition under the if somewhere else, but that could change in the future (unlikely, but could).
Can't
sk_X509_free
handleNULL
inputs? Then we don't even need a condition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that makes way more sense. The condition used to fail when I put in
untrusted != NULL
, but when you pointed that out, I realized OpenSSL had writtenuntrusted
to point to a reference ofbs->certs
orcerts
instead of duplicating it.Changed the behavior of
untrusted
to point to a copy instead of a pointer reference, and removed the condition sincesk_X509_free
takesNULL
inputs.