Add -text support to X509 tool, add Version tool #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1773 +/- ##
=======================================
Coverage 78.30% 78.31%
=======================================
Files 580 580
Lines 97002 97016 +14
Branches 13902 13903 +1
=======================================
+ Hits 75960 75975 +15
+ Misses 20422 20419 -3
- Partials 620 622 +2 ☔ View full report in Codecov by Sentry. |
justsmth
reviewed
Aug 16, 2024
samuel40791765
approved these changes
Aug 17, 2024
justsmth
approved these changes
Aug 20, 2024
skmcgrail
pushed a commit
to skmcgrail/aws-lc
that referenced
this pull request
Aug 22, 2024
### Description of changes: Add the -text option to the X509 tool which prints a certificate's contents in a human readable format. Also add the version tool which only supports printing the basic version information. ### Testing: Added a new test for X509 -text with some minor caveats due to difference in between OpenSSL versions. I didn't add a test for the version as that will always be different: ``` AWS-LC: OpenSSL 1.1.1 (compatible; AWS-LC 1.33.0) OpenSSL: OpenSSL 3.3.1 4 Jun 2024 (Library: OpenSSL 3.3.1 4 Jun 2024) ``` By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add the -text option to the X509 tool which prints a certificate's contents in a human readable format. Also add the version tool which only supports printing the basic version information.
Testing:
Added a new test for X509 -text with some minor caveats due to difference in between OpenSSL versions. I didn't add a test for the version as that will always be different:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.