-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include FIPS mode in OpenSSL_version return value #1689
Merged
WillChilds-Klein
merged 3 commits into
aws:fips-2022-11-02
from
WillChilds-Klein:pr-1419-fips-backport
Jul 3, 2024
Merged
Include FIPS mode in OpenSSL_version return value #1689
WillChilds-Klein
merged 3 commits into
aws:fips-2022-11-02
from
WillChilds-Klein:pr-1419-fips-backport
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes FIPS mode information in the return value of `OpenSSL_version(OPENSSL_VERSION)`. This will allow consumers of CPython (and likely other tools or language runtimes) to detect FIPS mode without calling to an AWS-LC-specific API, which would require either patching or forking the language or tool in question.
torben-hansen
previously approved these changes
Jul 3, 2024
darylmartin100
previously approved these changes
Jul 3, 2024
6297a4e
6297a4e
to
3f78067
Compare
darylmartin100
previously approved these changes
Jul 3, 2024
torben-hansen
previously approved these changes
Jul 3, 2024
skmcgrail
previously approved these changes
Jul 3, 2024
73e83bf
macOS 11 has [been deprecated][1] by GitHub actions runners. [1]: actions/runner-images#9255 (comment)
73e83bf
to
f61fc60
Compare
graebm
added a commit
to awslabs/aws-c-cal
that referenced
this pull request
Jul 3, 2024
**Issue**: The libcrypto runtime check isn't working with latest [AWS-LC-FIPS-2.0.13](https://github.com/aws/aws-lc/releases/tag/AWS-LC-FIPS-2.0.13) release. It's not returning the expected version string. AWS-LC is working on a fix here: aws/aws-lc#1689 **Description of changes:** This reverts commit 0cdbf2b. We'll bring this check right back once AWS-LC-FIPS has this fix in its latest release (on Github, and internally at Amazon). It seems simpler to remove the check entirely, and bring it back once things are working. Vs patching it now, and then patching it again, and then we have all these different versions of aws-lc/aws-c-cal that aren't compatible...
skmcgrail
approved these changes
Jul 3, 2024
torben-hansen
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves t/P138681213
Description of changes:
This backports PR 1419 to the 2022 FIPS branch. Confirmed that modifying
crypto.c
does not affect the FIPS module.Call-outs:
Testing:
Setup
Before this PR
After this PR
Ensure that Modifying Module Source Affects Hash
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.