Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EC seed functions as deprecated no-ops #1674

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

samuel40791765
Copy link
Contributor

Issues:

Addresses CryptoAlg-1715

Description of changes:

Ruby exposes the EC_GROUP seed functions and allows you to set the seed with EC_GROUP_set_seed. It's one thing that are EC_GROUPs are static and immutable, but setting the seed is more prevalent to custom curves. We don't encourage using custom curves, so I've chose to mark it as a no-op and deprecated.
We could arguably support EC_GROUP_get0_seed and EC_GROUP_get_seed_len for our named curves, but the seed value is only used during the initial curve parameter generation. We've chosen to mark this as a no-op for now, implementing them creates additional complexity that doesn't really provide additional value to the consumer.

Call-outs:

N/A

Testing:

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from dkostic June 28, 2024 20:39
@samuel40791765 samuel40791765 requested a review from a team as a code owner June 28, 2024 20:39
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.22%. Comparing base (e587bb5) to head (54e7b32).
Report is 55 commits behind head on main.

Files Patch % Lines
crypto/fipsmodule/ec/ec.c 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1674      +/-   ##
==========================================
+ Coverage   78.09%   78.22%   +0.12%     
==========================================
  Files         562      566       +4     
  Lines       94656    95190     +534     
  Branches    13574    13664      +90     
==========================================
+ Hits        73923    74462     +539     
+ Misses      20140    20131       -9     
- Partials      593      597       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 merged commit f6f9bdd into aws:main Jul 1, 2024
98 of 99 checks passed
@samuel40791765 samuel40791765 deleted the ec-seed branch July 1, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants