Update HMAC to fail when null value is passed to out parameter #1662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2522
Description of changes:
Currently,
NULL
passed as the value ofout
can result in a segmentation fault. This change adds checks to the HMAC one-shot API and HMAC_final function to handle scenarios whereNULL
is passed as a value to theout
parameter to return from the functions and prevent further computation.Testing:
Added additional test case in
crypto/hmac_extra/hmac_test.cc
to verify the behavior whenNULL
is passed as a value toout
in both functions.Call-outs:
OpenSSL supports this differently by allowing the computation to occur but allocating a throw-away array OpenSSL implementation
We should also evaluate if this change should be back-ported to the FIPS branches
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.