Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert _CET_ENDBR #1656

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Revert _CET_ENDBR #1656

merged 3 commits into from
Jun 21, 2024

Conversation

justsmth
Copy link
Contributor

Description of changes:

Revert:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner June 21, 2024 16:25
@justsmth justsmth changed the title Revert cet endbr Revert _CET_ENDBR Jun 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@c1c4383). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1656   +/-   ##
=======================================
  Coverage        ?   78.20%           
=======================================
  Files           ?      566           
  Lines           ?    95162           
  Branches        ?    13661           
=======================================
  Hits            ?    74421           
  Misses          ?    20146           
  Partials        ?      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@torben-hansen torben-hansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AWS / aws-lc-ci-integration dimension failed but it was some internal codebuild error. should be good.

@justsmth justsmth merged commit b681bb0 into aws:main Jun 21, 2024
97 of 99 checks passed
@justsmth justsmth deleted the revert-_CET_ENDBR branch June 21, 2024 18:15
justsmth added a commit that referenced this pull request Jul 12, 2024
### Issues:
* Addresses: CryptoAlg-2220

### Previous Work:
This change re-introduces changes from the following PRs:
* #1628

Due to build failures with certain environments using gcc-4.8, the above
was reverted:
* #1656

The build failures were addressed in the following PR:
* #1665

### Description of changes: 
Upstream commits: 
*
google/boringssl@9fc1c33
*
google/boringssl@51ed32f


By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.

---------

Co-authored-by: Bob Beck <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants