add support for EC_POINT_bn2point #1645
Conversation
include/openssl/ec.h
Outdated
| // On success, it returns the BIGNUM pointer supplied or, if |ret| is NULL, | ||
| // allocates and returns a fresh |BIGNUM|. On error, it returns NULL. The |ctx| | ||
| // argument may be used if not NULL. | ||
| OPENSSL_EXPORT OPENSSL_DEPRECATED BIGNUM *EC_POINT_point2bn( | ||
| const EC_GROUP *group, const EC_POINT *point, point_conversion_form_t form, | ||
| BIGNUM *ret, BN_CTX *ctx); | ||
|
|
||
| // EC_POINT_bn2point is like |EC_POINT_point2bn|, but converts a |BIGNUM| to an |
There was a problem hiding this comment.
this doesn't make sense (nor does the EC_POINT_point2bn documentation :)). An EC point consists of (at least) two coordinates x and y, which are usually of type BIGNUM. So what's the relation between bn and point?
There was a problem hiding this comment.
I see what you're saying now, OpenSSL also deprecated these functions for this reason.
I've reworded the function documentation to describe the actual relation (there's not really much of one, it's just another conversion of the serialized output).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
- Coverage 78.21% 78.19% -0.02%
==========================================
Files 571 571
Lines 95405 95458 +53
Branches 13705 13705
==========================================
+ Hits 74621 74647 +26
- Misses 20173 20201 +28
+ Partials 611 610 -1 ☔ View full report in Codecov by Sentry. |
Issues:
Addresses
CryptoAlg-1715Description of changes:
Ruby happens to consume this. This is deprecated in OpenSSL 3.0 and I've marked it likewise in AWS-LC as well. Although Ruby has generally moved off of deprecated 3.0 APIs, they still depend on this and later versions like 3.2 and 3.3 have not removed support for this either.
Call-outs:
N/A
Testing:
Tests built upon original tests for
EC_POINT_point2bn.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.