Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align gcc version with curl's CI #1633

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

samuel40791765
Copy link
Contributor

Description of changes:

Curl's tip of main is failing against a compiler warning specific to gcc-12 at the moment with -Werror enabled. This is causing errors in our integration CI. We enable the flag since Curl's CI enables it, but they run against gcc-11 for their CI.

I've submitted an issue to curl to fix it (curl/curl#13932), but we should use gcc-11 for our Curl CI to avoid with curl's main branch that are out of our control.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@samuel40791765 samuel40791765 requested a review from a team as a code owner June 12, 2024 22:07
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.14%. Comparing base (37ba0e2) to head (70d9bc8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1633      +/-   ##
==========================================
- Coverage   78.15%   78.14%   -0.02%     
==========================================
  Files         562      562              
  Lines       94638    94638              
  Branches    13573    13573              
==========================================
- Hits        73969    73952      -17     
- Misses      20075    20093      +18     
+ Partials      594      593       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samuel40791765 samuel40791765 changed the title Use gcc11 for curl CI align gcc version with curl's CI Jun 13, 2024
@samuel40791765 samuel40791765 merged commit 8075b54 into aws:main Jun 14, 2024
96 of 98 checks passed
@samuel40791765 samuel40791765 deleted the use-gcc11-curl branch June 14, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants