Always install libdecrepit for BoringSSL benchmark #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
approved these changes
Mar 27, 2024
| @@ -66,7 +66,7 @@ function build_openssl { | |||
| function build_boringssl { | |||
| git clone --depth 1 https://github.com/google/boringssl.git "${scratch_folder}/boringssl" | |||
| pushd "${scratch_folder}/boringssl" | |||
| echo "install_if_enabled(TARGETS decrepit EXPORT OpenSSLTargets ${INSTALL_DESTINATION_DEFAULT})" >> CMakeLists.txt | |||
| echo "install(TARGETS decrepit EXPORT OpenSSLTargets ${INSTALL_DESTINATION_DEFAULT})" >> CMakeLists.txt | |||
There was a problem hiding this comment.
INSTALL_DESTINATION_DEFAULT doesn't seem to be defined in the logs, is it needed or only used when (CMAKE_VERSION VERSION_LESS "3.14")?
samuel40791765
force-pushed
the
boring_speed
branch
from
9dcd9b7 to
7f3f0ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
==========================================
+ Coverage 76.97% 76.98% +0.01%
==========================================
Files 425 425
Lines 71546 71546
==========================================
+ Hits 55071 55079 +8
+ Misses 16475 16467 -8 ☔ View full report in Codecov by Sentry. |
skmcgrail
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
google/boringssl@2d7f6c6 changed how BoringSSL handles installing targets, update our small patch to use the latest way to install libdecrepit
Testing:
This is to unblock the failing CI.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.