Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to build and run existing Fuzz tests in our CI #122

Merged
merged 10 commits into from
Apr 5, 2021

Conversation

andrewhop
Copy link
Contributor

Issues:

Resolves CryptoAlg-651

Description of changes:

This adds 2 new CI targets: running the existing fuzz tests on ARM and x86. This uses EFS to store the shared and minimized corpus.

Other changes:

  • Cleanup common test directories and set common bash flags
    • Add -u to check for unset variables, also update existing checks for variables to handle this
  • Remove the pull image permission from the CodeBuild roles, we grant permission to the CodeBuild service principal already

Testing:

I have not deployed this change to the CI account. I can walk you through the changes in my account.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@bryce-shang bryce-shang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may have additional comments after deploying the code.

tests/ci/run_fuzz_tests.sh Show resolved Hide resolved
tests/ci/common_fuzz.sh Outdated Show resolved Hide resolved
tests/ci/cdk/cdk/aws_lc_github_fuzz_ci_stack.py Outdated Show resolved Hide resolved
tests/ci/cdk/cdk/aws_lc_github_fuzz_ci_stack.py Outdated Show resolved Hide resolved
tests/ci/cdk/cdk/aws_lc_github_fuzz_ci_stack.py Outdated Show resolved Hide resolved
tests/ci/run_fuzz_tests.sh Show resolved Hide resolved
@bryce-shang bryce-shang self-requested a review April 1, 2021 02:16
@bryce-shang
Copy link
Contributor

AWS CodeBuild BuildBatch us-west-2 (aws-lc-ci-fuzzing) — BuildBatch succeeded for project aws-lc-ci-fuzzing

This repo needs to mark the build as Required.

bryce-shang
bryce-shang previously approved these changes Apr 1, 2021
@bryce-shang
Copy link
Contributor

AWS CodeBuild BuildBatch us-west-2 (aws-lc-ci-fuzzing) — BuildBatch succeeded for project aws-lc-ci-fuzzing

This repo needs to mark the build as Required.

Changed the repo setting to make Fuzz as required approval.

@andrewhop andrewhop merged commit 5eafd2d into aws:main Apr 5, 2021
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Jul 22, 2024
Add `bignum_mont{mul,sqr}_p384_neon`, speed improvements/refactoring in tactics
s2n-bignum original commit: awslabs/s2n-bignum@cbef866
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 18, 2024
Add `bignum_mont{mul,sqr}_p384_neon`, speed improvements/refactoring in tactics
s2n-bignum original commit: awslabs/s2n-bignum@cbef866
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 18, 2024
Add `bignum_mont{mul,sqr}_p384_neon`, speed improvements/refactoring in tactics
s2n-bignum original commit: awslabs/s2n-bignum@cbef866

s2n-bignum original commit: awslabs/s2n-bignum@9f6dd7b
torben-hansen pushed a commit to torben-hansen/aws-lc that referenced this pull request Sep 19, 2024
Add `bignum_mont{mul,sqr}_p384_neon`, speed improvements/refactoring in tactics
s2n-bignum original commit: awslabs/s2n-bignum@cbef866
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Dec 5, 2024
Add `bignum_mont{mul,sqr}_p384_neon`, speed improvements/refactoring in tactics
dkostic pushed a commit to dkostic/aws-lc that referenced this pull request Dec 10, 2024
Add `bignum_mont{mul,sqr}_p384_neon`, speed improvements/refactoring in tactics
s2n-bignum original commit: awslabs/s2n-bignum@cbef866
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants