Pull in the latest changes from s2n-bignum (2023-08-04) #1139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
N/A
Description of changes:
This PR is splitted from #1108 and a successor of (already merged) #1114. This PR is independent from #1135.
This PR pulls in the vectorized versions of functions (which are verified) for montgomery multiplications in Graviton 2 from s2n-bignum. In consequence, this adds the following files from s2n-bignum: arm/fastmul/bignum_emontredc_8n_neon.S, arm/fastmul/bignum_kmul_16_32_neon.S, arm/fastmul/bignum_ksqr_16_32_neon.S, arm/fastmul/bignum_ksqr_16_32_neon.S, arm/fastmul/bignum_ksqr_32_64_neon.S
The commands used:
(The commands in the internal Quip document was used, with PATHS_TO_KEEP added to include the new 5 files)
Call-outs:
Point out areas that need special attention or support during the review process. Discuss architecture or design changes.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.