CryptoAlg-682: Improve AES-GCM on ARMv8 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkostic
reviewed
Apr 1, 2021
| $code.=<<___; | ||
| @ calculate H^3 and H^4 | ||
| vpmull.p64 $Xl,$H, $H2 | ||
| vpmull.p64 $Yl,$H2,$H2 |
There was a problem hiding this comment.
Can we fix the indentation throughout the file please?
nebeid
force-pushed
the
CA682-aes-gcm
branch
3 times, most recently
from
dc1142d to
8c2191f
Compare
by running: `$ python3 ./util/generate_build_files.py`
dkostic
previously approved these changes
Apr 13, 2021
and generated filed under `generated-src`
andrewhop
approved these changes
Apr 21, 2021
dkostic
approved these changes
Apr 23, 2021
WillChilds-Klein
pushed a commit
to WillChilds-Klein/aws-lc
that referenced
this pull request
Mar 9, 2022
Small fixups
aqjune-aws
pushed a commit
to aqjune-aws/aws-lc-public
that referenced
this pull request
Mar 6, 2024
Update curve25519_x25519{_byte} to make AWS-LC's delocator work
s2n-bignum original commit: awslabs/s2n-bignum@88324d8
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Jul 22, 2024
Update curve25519_x25519{_byte} to make AWS-LC's delocator work
s2n-bignum original commit: awslabs/s2n-bignum@88324d8
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
Update curve25519_x25519{_byte} to make AWS-LC's delocator work
s2n-bignum original commit: awslabs/s2n-bignum@88324d8
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
Update curve25519_x25519{_byte} to make AWS-LC's delocator work
s2n-bignum original commit: awslabs/s2n-bignum@88324d8
s2n-bignum original commit: awslabs/s2n-bignum@b134a7e
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 19, 2024
Update curve25519_x25519{_byte} to make AWS-LC's delocator work
s2n-bignum original commit: awslabs/s2n-bignum@88324d8
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 5, 2024
Update curve25519_x25519{_byte} to make AWS-LC's delocator work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves CryptoAlg-682
Description of changes:
AWS-LC lags OpenSSL by 14-18% in the performance of AES-GCM-128/256 on Armv8, while it exceeds it on x86_64.
This PR merges in the changes in OpenSSL's ghashv8-armx.pl as in OpenSSL 1.1.1k.
These changes extend Gueron's method from 2x-aggregate factor to 4x-aggregate (see slide 22 in Gueron's slides) and matches the implementation in ghash-x86_64.pl
Call-outs:
N/A
Testing:
Speed tests were run on ARMv8, 2.5GHz:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.