Mark include as PUBLIC not SYSTEM PUBLIC #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhop
previously approved these changes
Jul 6, 2023
justsmth
approved these changes
Jul 6, 2023
andrewhop
approved these changes
Jul 6, 2023
skmcgrail
added a commit
to skmcgrail/aws-lc
that referenced
this pull request
Jul 7, 2023
* Mark include as PUBLIC not SYSTEM PUBLIC * Update ssl target (cherry picked from commit 51917f8)
skmcgrail
added a commit
that referenced
this pull request
Jul 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue seen in aws-lc-rs where this would cause CMake to generate the makefile / ninja-build descriptions with the directory included using
-isystemrather then-I. This affects resolution order for headers as system includes are ranked lower in priority then-Iincludes.It seemed appropriate to fix this here, BoringSSL similarly has this marked as just public: https://github.com/google/boringssl/blob/master/crypto/CMakeLists.txt#L304
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.