CMake: Fix linking with compiler other than MSVC. #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, MSVC specific pragma comment are used to link with ws2_32 library. But those does not work with MinGW gcc and clang. Hence, use CMake's own target_link_libraries() to link with ws2_32 for Win32 platform conditionally.
dkostic
reviewed
Mar 3, 2021
| @@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 2.8.12) | |||
| # Defer enabling C and CXX languages. | |||
| project(AWSLC NONE) | |||
|
|
|||
| if(WIN32) | |||
| if(MSVC) | |||
There was a problem hiding this comment.
I didn't understand why is this line changed, could you please clarify?
There was a problem hiding this comment.
Because cl.exe is Visual Studio compiler and this PR is about when not compiling with Visual Studio.
|
Thanks for fixing this! We currently only test Windows with MSVC and that build is passing with this change. Windows with Clang is currently untested but we're happy to take this fix now and investigate adding more Windows builds in the future. How did you test this change? If you don't mind me asking, what is your use case for AWS-LC? |
|
Is 'just poking around' considered as use case? 😛 |
andrewhop
approved these changes
Mar 9, 2021
dkostic
approved these changes
Mar 9, 2021
aqjune-aws
pushed a commit
to aqjune-aws/aws-lc-public
that referenced
this pull request
Mar 4, 2024
* Allow MIT-0 license as well as Apache-2.0 and ISC * Add appropriate year range to MIT-0 license s2n-bignum original commit: awslabs/s2n-bignum@48fb153
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Jul 22, 2024
* Allow MIT-0 license as well as Apache-2.0 and ISC * Add appropriate year range to MIT-0 license s2n-bignum original commit: awslabs/s2n-bignum@48fb153
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
* Allow MIT-0 license as well as Apache-2.0 and ISC * Add appropriate year range to MIT-0 license s2n-bignum original commit: awslabs/s2n-bignum@48fb153
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 18, 2024
* Allow MIT-0 license as well as Apache-2.0 and ISC * Add appropriate year range to MIT-0 license s2n-bignum original commit: awslabs/s2n-bignum@48fb153 s2n-bignum original commit: awslabs/s2n-bignum@f133bad
torben-hansen
pushed a commit
to torben-hansen/aws-lc
that referenced
this pull request
Sep 19, 2024
* Allow MIT-0 license as well as Apache-2.0 and ISC * Add appropriate year range to MIT-0 license s2n-bignum original commit: awslabs/s2n-bignum@48fb153
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 5, 2024
* Allow MIT-0 license as well as Apache-2.0 and ISC * Add appropriate year range to MIT-0 license
dkostic
pushed a commit
to dkostic/aws-lc
that referenced
this pull request
Dec 10, 2024
* Allow MIT-0 license as well as Apache-2.0 and ISC * Add appropriate year range to MIT-0 license s2n-bignum original commit: awslabs/s2n-bignum@48fb153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, MSVC specific pragma comment are used to link with ws2_32 library.
But those does not work with MinGW gcc and clang. Hence, use CMake's own
target_link_libraries() to link with ws2_32 for Win32 platform conditionally.