Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fips MacOS failure due to -Woverriding-option #678

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 31, 2025

Context

Some users experiencing build failures relating to the following error:

  clang: error: overriding '-mmacosx-version-min=14.7' option with '--target=arm64-apple-macosx15.1' [-Werror,-Woverriding-option]
  make[2]: *** [aws-lc/crypto/fipsmodule/CMakeFiles/bcm_library.dir/bcm.c.o] Error 1

Description of changes:

  • This change applies the same fix for -Woverriding-option as we had done for -Woverriding-t-option.

Call-outs:

N/A

Testing:

A user experiencing this problem confirmed this change resolved it.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.84%. Comparing base (c358484) to head (2cf0e8c).
Report is 159 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   95.80%   92.84%   -2.96%     
==========================================
  Files          61       68       +7     
  Lines        8143     9747    +1604     
  Branches        0     9747    +9747     
==========================================
+ Hits         7801     9050    +1249     
- Misses        342      407      +65     
- Partials        0      290     +290     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@landonxjames
Copy link

Tested this fix locally and it solved my build issue, thank you!

@justsmth justsmth changed the title [DRAFT] Avoid fips MacOS failure due to -Woverriding-option Avoid fips MacOS failure due to -Woverriding-option Jan 31, 2025
@justsmth justsmth marked this pull request as ready for review January 31, 2025 18:47
@justsmth justsmth requested a review from a team as a code owner January 31, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants