Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ECDSA structs into ec::signature #654

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jan 9, 2025

Description of changes:

  • Migrate ECDSA structs/functions into ec::signature module.

Testing:

No changes to API detected.

❯ cargo public-api diff latest
...
Removed items from the public API
=================================
(none)

Changed items in the public API
===============================
(none)

Added items to the public API
=============================
(none)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner January 9, 2025 21:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 81.00559% with 34 lines in your changes missing coverage. Please review.

Project coverage is 92.89%. Comparing base (c358484) to head (ae056f4).
Report is 146 commits behind head on main.

Files with missing lines Patch % Lines
aws-lc-rs/src/ec/signature.rs 81.46% 20 Missing and 13 partials ⚠️
aws-lc-rs/src/ec/key_pair.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   95.80%   92.89%   -2.91%     
==========================================
  Files          61       68       +7     
  Lines        8143     9718    +1575     
  Branches        0     9718    +9718     
==========================================
+ Hits         7801     9028    +1227     
- Misses        342      402      +60     
- Partials        0      288     +288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the refactor-ec-signature branch from e417ce3 to ae056f4 Compare January 9, 2025 21:29
@justsmth justsmth merged commit f013911 into aws:main Jan 10, 2025
261 checks passed
@justsmth justsmth deleted the refactor-ec-signature branch January 10, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants