Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CI for riscv64gc-unknown-linux-gnu #507

Merged
merged 4 commits into from
Sep 3, 2024

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Aug 22, 2024

Description of changes:

  • Fix the cross-compilation test for riscv64.

Call-outs:

  • Added support for a AWS_LC_SYS_CFLAGS environment variable that allows custom compile flags to be provided by the environment.
    • This was needed as a way propagate the -Wno-string-compare flag from the environment.
    • A similar problem was solved this way in the AWS-LC CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.52%. Comparing base (c358484) to head (4d0f99e).
Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   95.80%   92.52%   -3.28%     
==========================================
  Files          61       67       +6     
  Lines        8143     9277    +1134     
  Branches        0     9277    +9277     
==========================================
+ Hits         7801     8584     +783     
- Misses        342      422      +80     
- Partials        0      271     +271     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth force-pushed the riscv64gc-cleanup branch 5 times, most recently from 7152781 to 0d7ff14 Compare August 22, 2024 02:58
@justsmth justsmth changed the title Remove riscv64gc-specific CI logic Restore CI for riscv64gc-unknown-linux-gnu Aug 22, 2024
@justsmth justsmth marked this pull request as ready for review August 22, 2024 03:24
@justsmth justsmth requested a review from a team as a code owner August 22, 2024 03:24
@justsmth justsmth force-pushed the riscv64gc-cleanup branch 2 times, most recently from 2db3a31 to 8139f90 Compare August 22, 2024 14:39
@justsmth justsmth requested review from skmcgrail, WillChilds-Klein and andrewhop and removed request for WillChilds-Klein August 22, 2024 16:09
skmcgrail
skmcgrail previously approved these changes Aug 27, 2024
andrewhop
andrewhop previously approved these changes Sep 3, 2024
@justsmth justsmth enabled auto-merge (squash) September 3, 2024 18:54
@justsmth justsmth merged commit 5c3dfc2 into aws:main Sep 3, 2024
190 of 198 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants