-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore CI for riscv64gc-unknown-linux-gnu
#507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
==========================================
- Coverage 95.80% 92.52% -3.28%
==========================================
Files 61 67 +6
Lines 8143 9277 +1134
Branches 0 9277 +9277
==========================================
+ Hits 7801 8584 +783
- Misses 342 422 +80
- Partials 0 271 +271 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
riscv64gc-cleanup
branch
5 times, most recently
from
August 22, 2024 02:58
7152781
to
0d7ff14
Compare
justsmth
changed the title
Remove riscv64gc-specific CI logic
Restore CI for Aug 22, 2024
riscv64gc-unknown-linux-gnu
justsmth
force-pushed
the
riscv64gc-cleanup
branch
2 times, most recently
from
August 22, 2024 14:39
2db3a31
to
8139f90
Compare
justsmth
requested review from
skmcgrail,
WillChilds-Klein and
andrewhop
and removed request for
WillChilds-Klein
August 22, 2024 16:09
skmcgrail
previously approved these changes
Aug 27, 2024
justsmth
force-pushed
the
riscv64gc-cleanup
branch
2 times, most recently
from
August 28, 2024 15:26
452fcc8
to
39b859d
Compare
andrewhop
previously approved these changes
Sep 3, 2024
justsmth
force-pushed
the
riscv64gc-cleanup
branch
from
September 3, 2024 18:46
39b859d
to
03e0df9
Compare
justsmth
force-pushed
the
riscv64gc-cleanup
branch
from
September 3, 2024 18:48
03e0df9
to
4d0f99e
Compare
skmcgrail
approved these changes
Sep 3, 2024
andrewhop
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Call-outs:
AWS_LC_SYS_CFLAGS
environment variable that allows custom compile flags to be provided by the environment.-Wno-string-compare
flag from the environment.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.