-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report bindgen version #494
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspect bindgen version
4c6928e
to
3606c6c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
==========================================
- Coverage 95.80% 92.69% -3.11%
==========================================
Files 61 63 +2
Lines 8143 8456 +313
Branches 0 8456 +8456
==========================================
+ Hits 7801 7838 +37
- Misses 342 361 +19
- Partials 0 257 +257 ☔ View full report in Codecov by Sentry. |
WillChilds-Klein
previously approved these changes
Aug 13, 2024
3e62b2d
to
3606c6c
Compare
WillChilds-Klein
approved these changes
Aug 14, 2024
skmcgrail
reviewed
Aug 19, 2024
Comment on lines
+585
to
+593
eprintln!( | ||
"bindgen-cli was used. Detected version was: {}.{}.{} \n\ | ||
If this is not the latest version, consider upgrading : \ | ||
`cargo install --force --locked bindgen-cli`\ | ||
\n\ | ||
See our User Guide for more information about bindgen:\ | ||
https://aws.github.io/aws-lc-rs/index.html", | ||
major_version, minor_version, patch_version | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
eprintln!( | |
"bindgen-cli was used. Detected version was: {}.{}.{} \n\ | |
If this is not the latest version, consider upgrading : \ | |
`cargo install --force --locked bindgen-cli`\ | |
\n\ | |
See our User Guide for more information about bindgen:\ | |
https://aws.github.io/aws-lc-rs/index.html", | |
major_version, minor_version, patch_version | |
); | |
eprintln!( | |
"bindgen-cli was used. Detected version was: {major_version}.{minor_version}.{patch_version} \n\ | |
If this is not the latest version, consider upgrading : \ | |
`cargo install --force --locked bindgen-cli`\ | |
\n\ | |
See our User Guide for more information about bindgen:\ | |
https://aws.github.io/aws-lc-rs/index.html" | |
); |
skmcgrail
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses: #484
Description of changes:
When external bindgen is used, inspect the version number detected and provide guidance on how to upgrade.
Call-outs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.