Bump MSRV to 1.63.0 #331
Closed
Bump MSRV to 1.63.0 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
force-pushed
the
bump-msrv-1.61
branch
from
b8e5171 to
554012b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 62 62
Lines 8025 8025
=======================================
Hits 7690 7690
Misses 335 335 ☔ View full report in Codecov by Sentry. |
toidiu
reviewed
Jan 31, 2024
|
|
||
| - name: Verify msrv | ||
| working-directory: ./aws-lc-rs | ||
| run: cargo msrv --log-level debug --log-target stdout verify -- cargo check --features bindgen |
There was a problem hiding this comment.
Any reason this cant be build --all-features so its a bit more comprehensive?
Suggested change
| run: cargo msrv --log-level debug --log-target stdout verify -- cargo check --features bindgen | |
| run: cargo msrv --log-level debug --log-target stdout verify -- cargo build --all-features |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
This PR originally proposed bumping MSRV to 1.61.0.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.