Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use classic comment style for CMakelists copyright notice #304

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

WesleyRosenblum
Copy link
Contributor

Description of changes:

The multiline comment at the top of CMakeLists.txt is only supported by CMake 3.0+. This means the cmake_minimum_required(VERSION 3.0) check on subsequent lines is not reached when using older versions of CMake, so you end up with an error such as:

Parse error.  Expected "(", got unquoted argument with text "Amazon.com,".

This change switches to using comments supported by older versions of CMake so the cmake_minimum_required can produce a more useful error message.

Testing:

CI

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@WesleyRosenblum WesleyRosenblum requested a review from a team as a code owner December 21, 2023 01:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (28dc103) 95.27% compared to head (ec56c75) 95.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   95.27%   95.27%           
=======================================
  Files          55       55           
  Lines        7010     7010           
=======================================
  Hits         6679     6679           
  Misses        331      331           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justsmth justsmth merged commit 4de01fc into aws:main Dec 21, 2023
103 of 109 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants