Add Sha224 digest, HMAC-SHA224, and SHA224 KAT #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justsmth
reviewed
Jul 24, 2023
justsmth
previously approved these changes
Jul 25, 2023
justsmth
reviewed
Jul 25, 2023
justsmth
reviewed
Jul 25, 2023
justsmth
dismissed
their stale review
I suspect SHA225 chaining length is incorrect.
justsmth
previously approved these changes
Jul 25, 2023
There was a problem hiding this comment.
The "api-diff" CI appears to be triggered by the change to SHA1_OUTPUT_LEN, but I believe this is a false positive.
Changed items in the public API
===============================
-pub const aws_lc_rs::digest::SHA1_OUTPUT_LEN: OUTPUT_LEN
+pub const aws_lc_rs::digest::SHA1_OUTPUT_LEN: _
samuel40791765
approved these changes
Jul 26, 2023
justsmth
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.