Support otfMetadata in Kinesis firehose response metadata for iceberg table routing #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanhagen
reviewed
Feb 6, 2025
| @@ -5,15 +5,25 @@ | |||
| "recordId": "record1", | |||
| "result": "TRANSFORMED_STATE_OK", | |||
| "metadata": { | |||
| "partitionKeys": {} | |||
| "partitionKeys": {}, | |||
| "otfMetadata": { | |||
There was a problem hiding this comment.
How does Firehose handle metadata with empty strings? Will this cause an error? IE, if I want to transform but not route, what happens?
There was a problem hiding this comment.
Without knowing Firehose's behavior, it'd be prudent to add 'omitempty' to the new struct tag
bmoffatt
reviewed
Feb 19, 2025
| const ( | ||
| KinesisFirehoseOtfOperationInsert = "insert" | ||
| KinesisFirehoseOtfOperationUpdate = "update" | ||
| KinesisFirehoseOtfOperationDelete = "delete" |
There was a problem hiding this comment.
Expected type KinesisFirehoseOTFOperation string, like is done elsewhere for similar enum-likes in other events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #575
Add otfMetadata in metadata for firehose kinesis response record to support table routing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.