Skip to content

Add sanitizer CI job #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 77 commits into from
Feb 24, 2025
Merged

Add sanitizer CI job #703

merged 77 commits into from
Feb 24, 2025

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Mar 28, 2024 •
edited
Loading

Add CI jobs with TSAN and ASAN sanitizers enabled.
All issues found by these jobs were fixed in separate PRs to keep the size of this PR within limits.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sfodagain and others added 30 commits March 28, 2024 15:51
@sfodagain
Add sanitizer CI job
3ce2674
@sfodagain
Add creds for sanitizer job
1a87c51
@sfodagain
Add permissions to CI job
408187f
@sfodagain
Fix device defender cmake configs
514efcb
@sfodagain
Fix target_link_libraries
b3170b0
@sfodagain
Check if sanitizer works
edec814
@sfodagain
Revert leak check
030eb69
@sfodagain
Enable sanitizer for jobs
8172f67
@sfodagain
Verify sanitizer works
9691b60
@sfodagain
Fix adding sanitizer in tests
1f5a388
@sfodagain
Fix sanitizer for tests
4fcc0dc
@sfodagain
Change building
d208305
@sfodagain
Define builder variants
673b32f
@sfodagain
Fix typo
1395a76
@sfodagain
Fix builder.json
1ca715c
@sfodagain
Enable sanitizer for all
ce3c578
@sfodagain
Fix typo
8f421ec
@sfodagain
Fun with gg
aa3f06a
@sfodagain
Fix target_link_library
219304f
@sfodagain
Install softhsm
6420132
@sfodagain
Remove test leak
c6f2980
@alfred2g
Merge branch 'main' into add-sanitizer-ci-job
40080ac
@sfodagain
Merge branch 'main' into add-sanitizer-ci-job
279733d
@sfodagain
Merge branch 'main' into add-sanitizer-ci-job
7e73a5e
@sfodagain
Remove extra params in running samples
1ffefd5
@sfodagain
Capture and print
5128e10
@sfodagain
fixup
91d09b7
@sfodagain
Fix memory and data race issues
72b2582
@sfodagain
Refactor jobs service test
d4468ba
@sfodagain
Remove mqtt3 client from comd utils
f5ca4b5
@sfod sfod mentioned this pull request Sep 10, 2024
Merged
@sfod sfod marked this pull request as ready for review December 3, 2024 00:33
@sfod
Copy link
Contributor Author

sfod commented Feb 21, 2025 •
edited
Loading

awslabs/aws-c-common#1190 will allow to remove enable_language(C) lines from cmake configs, but it'll probably take some time to bring it to the SDK layer.
This small style improvement should not be a show stopper for this PR, in my opinion.

bretambrose
bretambrose approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix n merge

@sfod sfod merged commit f731816 into main Feb 24, 2025
40 of 41 checks passed
@sfod sfod deleted the add-sanitizer-ci-job branch February 24, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretambrose bretambrose bretambrose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfod @bretambrose @sfodagain @alfred2g