Update Greengrass V2 IPC models #450
Conversation
| @@ -5864,6 +6878,75 @@ namespace Aws | |||
| return m_operationModelContext.GetOperationName(); | |||
| } | |||
|
|
|||
| GetClientDeviceAuthTokenOperationContext::GetClientDeviceAuthTokenOperationContext( | |||
There was a problem hiding this comment.
This function is empty. Is this supposed to be empty? I would expect it to return something since, based on the function name GetClientDeviceAuthTokenOperationContext
Edit: Ah, I see now. It is calling the OperationModelContext function in the constructor of the function. Ideally I'd like a comment here mentioning that, as initially it looks just like an empty function. However, this is not a requirement, now that I know to look for it, it makes sense.
| return GetClientDeviceAuthTokenResponse::s_allocateFromPayload(stringView, allocator); | ||
| } | ||
|
|
||
| Aws::Crt::ScopedResource<AbstractShapeBase> GetClientDeviceAuthTokenOperationContext:: |
There was a problem hiding this comment.
Ditto for this one - seems kinda pointless since it does not do anything.
| ClientConnection &connection, | ||
| const VerifyClientDeviceIdentityOperationContext &operationContext, | ||
| Aws::Crt::Allocator *allocator) noexcept | ||
| : ClientOperation(connection, nullptr, operationContext, allocator) |
There was a problem hiding this comment.
Same general remark on the constructors: A comment would be nice but not required.
| return m_operationModelContext.GetOperationName(); | ||
| } | ||
|
|
||
| AuthorizeClientDeviceActionOperationContext::AuthorizeClientDeviceActionOperationContext( |
There was a problem hiding this comment.
Same general remark on the constructors: A comment would be nice but not required.
| }); | ||
| } | ||
|
|
||
| AuthorizeClientDeviceActionOperation::AuthorizeClientDeviceActionOperation( |
There was a problem hiding this comment.
Same general remark on the constructors: A comment would be nice but not required.
|
Absolutely all of this is autogenerated from our code generators which have not been modified. The methods which return nullptr or empty strings are correct because those operations do not have any streaming response for example, they only have an immediate response. |
|
Ah okay, that makes sense. Thank you for clarifying! I will resolve the comments on the functions that return |
|
Thank you for the changes! Merging into |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.