fix(eventstream): move ContinuationCallbackData into ClientContinuation to fix memory leak #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on to fix memory leak
MikeDombo
force-pushed
the
event-stream-leak
branch
from
78b85a0 to
d5d58e5
Compare
sbSteveK
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixes a memory leak in event stream due to
ContinuationCallbackDatabeing held by the actual connection and only destroyed on connection shutdown. This means that every single request will cause a leak of ~127 bytes which won't be cleaned until the whole connection dies. This change removes the vector of callback data from the connection and instead stores the continuation callback data with the actual continuation which created it. It is then destroyed in the continuation's destructor.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.