Device Defender custom metrics support #401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got the initial, proof-of-concept solution for passing a custom metric function to device defender from C++. Rough around the edges currently and only supports number functions, but it compiles and seems to work in the test! Need to verify results but committing to ensure changes are saved.
…e function pointer
… into DeviceDefenderCustomMetricsSupport
TwistedTwigleg
commented
Mar 15, 2022
…ocation, and updated sample and tests
…om/aws/aws-iot-device-sdk-cpp-v2 into DeviceDefenderCustomMetricsSupport
… into DeviceDefenderCustomMetricsSupport
|
Note: This PR relies on the changes in awslabs/aws-c-iot#67 in order to compile successfully, since it adds some new functions for custom metrics using doubles. |
graebm
reviewed
Mar 16, 2022
…or custom metrics. Currently custom numbers, number lists, and the tests for numbers work. Custom strings and IP cause segfault currently
…om/aws/aws-iot-device-sdk-cpp-v2 into DeviceDefenderCustomMetricsSupport
|
I pushed the first part of the changes based on the code review, but I have not fully implemented it just yet. Currently custom metrics for strings and IP lists are not working, causing segmentation faults when they are written to JSON. I think it is the strings are going out of reference. |
…her than reference and that was causing the crash
…om/aws/aws-iot-device-sdk-cpp-v2 into DeviceDefenderCustomMetricsSupport
…get CPU, memory, and process usage
… into DeviceDefenderCustomMetricsSupport
… into DeviceDefenderCustomMetricsSupport
…onnection builder in sample
bretambrose
reviewed
May 5, 2022
…om register functions to be passed by value
bretambrose
approved these changes
May 6, 2022
|
Thanks for the reviews! Merging into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds support for registering custom metrics to the Device Defender service. Exposes functions to hook into Device Defender number, number-list, string-list, and ip-list metric gathering. Adds new functions to
Aws::Iotdevicedefenderv1to register these custom metrics either by passing a function pointer or astd::function. Adds predefined custom metric functions that will get CPU usage (in percent), memory usage (in kilobytes) and process count.This PR also adds a device defender sample to show how to use and register custom metrics and custom metrics tests to the existing Device Defender tests.
aws-c-iotPR that accompanies this PR: awslabs/aws-c-iot#67By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.