chore: Update dependency on boto3 #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottarc
approved these changes
Feb 2, 2021
robin-aws
pushed a commit
to robin-aws/aws-encryption-sdk-python
that referenced
this pull request
Apr 27, 2021
robin-aws
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Now that we're passing key ids to KMS Decrypt operations, we need to make sure our boto version knows that Decrypt accepts KeyId as a parameter, otherwise client-side request validation fails.
Testing:
Installed version 1.10 of boto3, confirmed that encrypt/decrypt operations succeed. Versions prior to 1.10 fail with
ParamValidationError: Unknown parameter in input: "KeyId", must be one of: CiphertextBlob, EncryptionContext, GrantTokens")By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.