Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultCryptoMaterialsManager docstring incorrectly indicates that algorithm is a configurable parameter #8

Closed
mattsb42 opened this issue Aug 20, 2017 · 1 comment
Closed

DefaultCryptoMaterialsManager docstring incorrectly indicates that algorithm is a configurable parameter #8

mattsb42 opened this issue Aug 20, 2017 · 1 comment
Assignees
@mattsb42-aws
Labels
bug

Comments

@mattsb42
Copy link

DefaultCrytoMaterialsManager docstring incorrectly indicates that algorithm is configurable. Behavior is as intended, but I missed clearing out this docstring.

https://github.com/awslabs/aws-encryption-sdk-python/blob/b6a2bbca4db6ab46d65fe7e2eacfffe25abff3a2/aws_encryption_sdk/materials_managers/default.py#L26
@mattsb42-aws mattsb42-aws self-assigned this Aug 21, 2017
@mattsb42-aws mattsb42-aws mentioned this issue Sep 12, 2017
Merged
lizroth pushed a commit that referenced this issue Sep 12, 2017
@mattsb42-aws @lizroth
removing algorithm parameter from DefaultCryptoMaterialsManager docst…
9e018c7 
…ring #8
@mattsb42-aws
Copy link
Member

This is addressed in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsb42-aws mattsb42-aws

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattsb42 @mattsb42-aws