chore: update gh token #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
requested changes
Nov 12, 2021
| - git config --global user.name "aws-crypto-tools-ci-bot" | ||
| - git config --global user.email "[email protected]" | ||
| - echo $GH_TOKEN > token.txt | ||
| - export GH_TOKEN= |
There was a problem hiding this comment.
Suggested change
| - export GH_TOKEN= | |
| - export -n GH_TOKEN |
The above assumes that terminal CodeBuild provides us is bash. If it is zsh, my suggestion will fail.
But it is not: https://docs.aws.amazon.com/codebuild/latest/userguide/build-spec-ref.html#build-spec.shell
And both sh and bash support the -n flag on export.
There was a problem hiding this comment.
ooh i like that better it is much cleaner. i'll test this and get back to you if we still have the same result
There was a problem hiding this comment.
big oof! unfortunately the export -n option returns with export: Illegal option -n
There was a problem hiding this comment.
For the record, CodeBuild does not support -n on export. We could probably use unset, but testing this is manual and time consuming, so I am approving this as is.
texastony
approved these changes
Nov 12, 2021
aws-crypto-tools-ci-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
## [2.4.0](v2.3.3...v2.4.0) (2022-03-09) ### Features * AWS SDK v2 support ([006cdc4](006cdc4)) ### Maintenance * Add back removed CiphertextHeaders.deserialize method ([#382](#382)) ([c1f3e63](c1f3e63)) * add build to support uploading artifacts ([#379](#379)) ([69e7914](69e7914)) * Add CODEOWNERS file ([#406](#406)) ([b9adf9f](b9adf9f)) * add javadoc update to batch build ([#376](#376)) ([d88190b](d88190b)) * Adding semantic release config file ([#346](#346)) ([6201c1a](6201c1a)) * **deps-dev:** bump junit-jupiter-api from 5.7.2 to 5.8.0 ([#339](#339)) ([6dfaef9](6dfaef9)) * **deps-dev:** bump junit-jupiter-api from 5.8.0 to 5.8.1 ([#347](#347)) ([7d3bb0a](7d3bb0a)) * **deps-dev:** bump junit-jupiter-api from 5.8.1 to 5.8.2 ([#427](#427)) ([7de569a](7de569a)) * **deps-dev:** bump junit-vintage-engine from 5.7.2 to 5.8.0 ([#337](#337)) ([2338b92](2338b92)) * **deps-dev:** bump junit-vintage-engine from 5.8.0 to 5.8.1 ([#348](#348)) ([d0221cf](d0221cf)) * **deps-dev:** bump junit-vintage-engine from 5.8.1 to 5.8.2 ([#426](#426)) ([065ab94](065ab94)) * **deps-dev:** bump mockito-core from 3.12.3 to 3.12.4 ([#323](#323)) ([0208d0d](0208d0d)) * **deps-dev:** bump mockito-core from 4.0.0 to 4.1.0 ([#441](#441)) ([8dfda1a](8dfda1a)) * **deps-dev:** bump mockito-core from 4.1.0 to 4.2.0 ([#458](#458)) ([a1b1885](a1b1885)) * **deps-dev:** bump mockito-core from 4.2.0 to 4.3.1 ([#500](#500)) ([a709e69](a709e69)) * **deps:** bump aws-java-sdk from 1.12.102 to 1.12.105 ([#404](#404)) ([b87d8c6](b87d8c6)) * **deps:** bump aws-java-sdk from 1.12.105 to 1.12.106 ([#405](#405)) ([dd633c0](dd633c0)) * **deps:** bump aws-java-sdk from 1.12.106 to 1.12.127 ([#436](#436)) ([91f6ffc](91f6ffc)) * **deps:** bump aws-java-sdk from 1.12.127 to 1.12.128 ([#437](#437)) ([37078ec](37078ec)) * **deps:** bump aws-java-sdk from 1.12.128 to 1.12.129 ([#447](#447)) ([6872c63](6872c63)) * **deps:** bump aws-java-sdk from 1.12.129 to 1.12.131 ([#463](#463)) ([a98a321](a98a321)) * **deps:** bump aws-java-sdk from 1.12.131 to 1.12.150 ([#508](#508)) ([433dc1b](433dc1b)) * **deps:** bump aws-java-sdk from 1.12.150 to 1.12.151 ([#510](#510)) ([70257a5](70257a5)) * **deps:** bump aws-java-sdk from 1.12.151 to 1.12.162 ([#541](#541)) ([22abc6c](22abc6c)) * **deps:** bump aws-java-sdk from 1.12.54 to 1.12.68 ([#341](#341)) ([291be0a](291be0a)) * **deps:** bump aws-java-sdk from 1.12.68 to 1.12.73 ([#350](#350)) ([153a0b3](153a0b3)) * **deps:** bump aws-java-sdk from 1.12.73 to 1.12.74 ([#351](#351)) ([e5f3962](e5f3962)) * **deps:** bump aws-java-sdk from 1.12.74 to 1.12.75 ([#353](#353)) ([3339c20](3339c20)) * **deps:** bump aws-java-sdk from 1.12.75 to 1.12.102 ([#400](#400)) ([98b079c](98b079c)) * **deps:** bump bcprov-ext-jdk15on from 1.69 to 1.70 ([#439](#439)) ([969852a](969852a)) * **deps:** bump build-helper-maven-plugin from 3.2.0 to 3.3.0 ([#473](#473)) ([4f7d08c](4f7d08c)) * **deps:** bump fmt-maven-plugin from 2.12 to 2.13 ([#429](#429)) ([e5d8c32](e5d8c32)) * **deps:** bump maven-compiler-plugin from 3.8.1 to 3.9.0 ([#481](#481)) ([369a049](369a049)) * **deps:** bump maven-javadoc-plugin from 3.3.0 to 3.3.1 ([#333](#333)) ([693e43f](693e43f)) * **deps:** bump nexus-staging-maven-plugin from 1.6.8 to 1.6.11 ([#535](#535)) ([0ab1db0](0ab1db0)) * **docs:** update README get started example ([#423](#423)) ([da0fe89](da0fe89)) * **docs:** updating broken javadoc link ([#366](#366)) ([487be4b](487be4b)) * moving and renaming buildspec.yml ([#360](#360)) ([e259caf](e259caf)) * release updates ([#369](#369)) ([4b9d932](4b9d932)) * source controlling cfn templates that will be used for our release process ([#345](#345)) ([456dda0](456dda0)) * update dependabot to update mainline-1.x ([#440](#440)) ([960f3e5](960f3e5)) * update gh token ([#412](#412)) ([f8ada9b](f8ada9b)) * update release process ([#396](#396)) ([c0ff093](c0ff093)) * update releaserc to include pom.xml file ([#357](#357)) ([63e2f05](63e2f05)) * update token name and timeout ([#411](#411)) ([c0d5a0e](c0d5a0e)) * updating prod template to remove resources and abstract ones ([#354](#354)) ([ecc17a6](ecc17a6)) * Upgrade mockito to 4.0.0 ([#438](#438)) ([629dbfd](629dbfd))
aws-crypto-tools-ci-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
## [2.4.0](v2.3.3...v2.4.0) (2022-03-09) ### Features * AWS SDK v2 support ([006cdc4](006cdc4)) ### Maintenance * Add back removed CiphertextHeaders.deserialize method ([#382](#382)) ([c1f3e63](c1f3e63)) * add build to support uploading artifacts ([#379](#379)) ([69e7914](69e7914)) * Add CODEOWNERS file ([#406](#406)) ([b9adf9f](b9adf9f)) * add javadoc update to batch build ([#376](#376)) ([d88190b](d88190b)) * Adding semantic release config file ([#346](#346)) ([6201c1a](6201c1a)) * **deps-dev:** bump junit-jupiter-api from 5.7.2 to 5.8.0 ([#339](#339)) ([6dfaef9](6dfaef9)) * **deps-dev:** bump junit-jupiter-api from 5.8.0 to 5.8.1 ([#347](#347)) ([7d3bb0a](7d3bb0a)) * **deps-dev:** bump junit-jupiter-api from 5.8.1 to 5.8.2 ([#427](#427)) ([7de569a](7de569a)) * **deps-dev:** bump junit-vintage-engine from 5.7.2 to 5.8.0 ([#337](#337)) ([2338b92](2338b92)) * **deps-dev:** bump junit-vintage-engine from 5.8.0 to 5.8.1 ([#348](#348)) ([d0221cf](d0221cf)) * **deps-dev:** bump junit-vintage-engine from 5.8.1 to 5.8.2 ([#426](#426)) ([065ab94](065ab94)) * **deps-dev:** bump mockito-core from 3.12.3 to 3.12.4 ([#323](#323)) ([0208d0d](0208d0d)) * **deps-dev:** bump mockito-core from 4.0.0 to 4.1.0 ([#441](#441)) ([8dfda1a](8dfda1a)) * **deps-dev:** bump mockito-core from 4.1.0 to 4.2.0 ([#458](#458)) ([a1b1885](a1b1885)) * **deps-dev:** bump mockito-core from 4.2.0 to 4.3.1 ([#500](#500)) ([a709e69](a709e69)) * **deps:** bump aws-java-sdk from 1.12.102 to 1.12.105 ([#404](#404)) ([b87d8c6](b87d8c6)) * **deps:** bump aws-java-sdk from 1.12.105 to 1.12.106 ([#405](#405)) ([dd633c0](dd633c0)) * **deps:** bump aws-java-sdk from 1.12.106 to 1.12.127 ([#436](#436)) ([91f6ffc](91f6ffc)) * **deps:** bump aws-java-sdk from 1.12.127 to 1.12.128 ([#437](#437)) ([37078ec](37078ec)) * **deps:** bump aws-java-sdk from 1.12.128 to 1.12.129 ([#447](#447)) ([6872c63](6872c63)) * **deps:** bump aws-java-sdk from 1.12.129 to 1.12.131 ([#463](#463)) ([a98a321](a98a321)) * **deps:** bump aws-java-sdk from 1.12.131 to 1.12.150 ([#508](#508)) ([433dc1b](433dc1b)) * **deps:** bump aws-java-sdk from 1.12.150 to 1.12.151 ([#510](#510)) ([70257a5](70257a5)) * **deps:** bump aws-java-sdk from 1.12.151 to 1.12.162 ([#541](#541)) ([22abc6c](22abc6c)) * **deps:** bump aws-java-sdk from 1.12.54 to 1.12.68 ([#341](#341)) ([291be0a](291be0a)) * **deps:** bump aws-java-sdk from 1.12.68 to 1.12.73 ([#350](#350)) ([153a0b3](153a0b3)) * **deps:** bump aws-java-sdk from 1.12.73 to 1.12.74 ([#351](#351)) ([e5f3962](e5f3962)) * **deps:** bump aws-java-sdk from 1.12.74 to 1.12.75 ([#353](#353)) ([3339c20](3339c20)) * **deps:** bump aws-java-sdk from 1.12.75 to 1.12.102 ([#400](#400)) ([98b079c](98b079c)) * **deps:** bump bcprov-ext-jdk15on from 1.69 to 1.70 ([#439](#439)) ([969852a](969852a)) * **deps:** bump build-helper-maven-plugin from 3.2.0 to 3.3.0 ([#473](#473)) ([4f7d08c](4f7d08c)) * **deps:** bump fmt-maven-plugin from 2.12 to 2.13 ([#429](#429)) ([e5d8c32](e5d8c32)) * **deps:** bump maven-compiler-plugin from 3.8.1 to 3.9.0 ([#481](#481)) ([369a049](369a049)) * **deps:** bump maven-javadoc-plugin from 3.3.0 to 3.3.1 ([#333](#333)) ([693e43f](693e43f)) * **deps:** bump nexus-staging-maven-plugin from 1.6.11 to 1.6.12 ([#546](#546)) ([6fa782b](6fa782b)) * **deps:** bump nexus-staging-maven-plugin from 1.6.8 to 1.6.11 ([#535](#535)) ([0ab1db0](0ab1db0)) * **docs:** update README get started example ([#423](#423)) ([da0fe89](da0fe89)) * **docs:** updating broken javadoc link ([#366](#366)) ([487be4b](487be4b)) * moving and renaming buildspec.yml ([#360](#360)) ([e259caf](e259caf)) * release updates ([#369](#369)) ([4b9d932](4b9d932)) * source controlling cfn templates that will be used for our release process ([#345](#345)) ([456dda0](456dda0)) * update dependabot to update mainline-1.x ([#440](#440)) ([960f3e5](960f3e5)) * update gh token ([#412](#412)) ([f8ada9b](f8ada9b)) * update release process ([#396](#396)) ([c0ff093](c0ff093)) * update releaserc to include pom.xml file ([#357](#357)) ([63e2f05](63e2f05)) * update token name and timeout ([#411](#411)) ([c0d5a0e](c0d5a0e)) * updating prod template to remove resources and abstract ones ([#354](#354)) ([ecc17a6](ecc17a6)) * Upgrade mockito to 4.0.0 ([#438](#438)) ([629dbfd](629dbfd))
aws-crypto-tools-ci-bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
## [2.4.0](v2.3.3...v2.4.0) (2022-03-09) ### Features * AWS SDK v2 support ([006cdc4](006cdc4)) ### Fixes * Revert "AWS Encryption SDK 2.4.0 Release -- $(date +%Y-%m-%d)" ([7563a95](7563a95)) ### Maintenance * Add back removed CiphertextHeaders.deserialize method ([#382](#382)) ([c1f3e63](c1f3e63)) * add build to support uploading artifacts ([#379](#379)) ([69e7914](69e7914)) * Add CODEOWNERS file ([#406](#406)) ([b9adf9f](b9adf9f)) * add javadoc update to batch build ([#376](#376)) ([d88190b](d88190b)) * Adding semantic release config file ([#346](#346)) ([6201c1a](6201c1a)) * **ci:** change release vars ([#578](#578)) ([de99b56](de99b56)) * **deps-dev:** bump junit-jupiter-api from 5.7.2 to 5.8.0 ([#339](#339)) ([6dfaef9](6dfaef9)) * **deps-dev:** bump junit-jupiter-api from 5.8.0 to 5.8.1 ([#347](#347)) ([7d3bb0a](7d3bb0a)) * **deps-dev:** bump junit-jupiter-api from 5.8.1 to 5.8.2 ([#427](#427)) ([7de569a](7de569a)) * **deps-dev:** bump junit-vintage-engine from 5.7.2 to 5.8.0 ([#337](#337)) ([2338b92](2338b92)) * **deps-dev:** bump junit-vintage-engine from 5.8.0 to 5.8.1 ([#348](#348)) ([d0221cf](d0221cf)) * **deps-dev:** bump junit-vintage-engine from 5.8.1 to 5.8.2 ([#426](#426)) ([065ab94](065ab94)) * **deps-dev:** bump mockito-core from 3.12.3 to 3.12.4 ([#323](#323)) ([0208d0d](0208d0d)) * **deps-dev:** bump mockito-core from 4.0.0 to 4.1.0 ([#441](#441)) ([8dfda1a](8dfda1a)) * **deps-dev:** bump mockito-core from 4.1.0 to 4.2.0 ([#458](#458)) ([a1b1885](a1b1885)) * **deps-dev:** bump mockito-core from 4.2.0 to 4.3.1 ([#500](#500)) ([a709e69](a709e69)) * **deps:** bump aws-java-sdk from 1.12.102 to 1.12.105 ([#404](#404)) ([b87d8c6](b87d8c6)) * **deps:** bump aws-java-sdk from 1.12.105 to 1.12.106 ([#405](#405)) ([dd633c0](dd633c0)) * **deps:** bump aws-java-sdk from 1.12.106 to 1.12.127 ([#436](#436)) ([91f6ffc](91f6ffc)) * **deps:** bump aws-java-sdk from 1.12.127 to 1.12.128 ([#437](#437)) ([37078ec](37078ec)) * **deps:** bump aws-java-sdk from 1.12.128 to 1.12.129 ([#447](#447)) ([6872c63](6872c63)) * **deps:** bump aws-java-sdk from 1.12.129 to 1.12.131 ([#463](#463)) ([a98a321](a98a321)) * **deps:** bump aws-java-sdk from 1.12.131 to 1.12.150 ([#508](#508)) ([433dc1b](433dc1b)) * **deps:** bump aws-java-sdk from 1.12.150 to 1.12.151 ([#510](#510)) ([70257a5](70257a5)) * **deps:** bump aws-java-sdk from 1.12.151 to 1.12.162 ([#541](#541)) ([22abc6c](22abc6c)) * **deps:** bump aws-java-sdk from 1.12.54 to 1.12.68 ([#341](#341)) ([291be0a](291be0a)) * **deps:** bump aws-java-sdk from 1.12.68 to 1.12.73 ([#350](#350)) ([153a0b3](153a0b3)) * **deps:** bump aws-java-sdk from 1.12.73 to 1.12.74 ([#351](#351)) ([e5f3962](e5f3962)) * **deps:** bump aws-java-sdk from 1.12.74 to 1.12.75 ([#353](#353)) ([3339c20](3339c20)) * **deps:** bump aws-java-sdk from 1.12.75 to 1.12.102 ([#400](#400)) ([98b079c](98b079c)) * **deps:** bump bcprov-ext-jdk15on from 1.69 to 1.70 ([#439](#439)) ([969852a](969852a)) * **deps:** bump build-helper-maven-plugin from 3.2.0 to 3.3.0 ([#473](#473)) ([4f7d08c](4f7d08c)) * **deps:** bump fmt-maven-plugin from 2.12 to 2.13 ([#429](#429)) ([e5d8c32](e5d8c32)) * **deps:** bump maven-compiler-plugin from 3.8.1 to 3.9.0 ([#481](#481)) ([369a049](369a049)) * **deps:** bump maven-javadoc-plugin from 3.3.0 to 3.3.1 ([#333](#333)) ([693e43f](693e43f)) * **deps:** bump nexus-staging-maven-plugin from 1.6.11 to 1.6.12 ([#546](#546)) ([6fa782b](6fa782b)) * **deps:** bump nexus-staging-maven-plugin from 1.6.8 to 1.6.11 ([#535](#535)) ([0ab1db0](0ab1db0)) * **docs:** update README get started example ([#423](#423)) ([da0fe89](da0fe89)) * **docs:** updating broken javadoc link ([#366](#366)) ([487be4b](487be4b)) * moving and renaming buildspec.yml ([#360](#360)) ([e259caf](e259caf)) * release updates ([#369](#369)) ([4b9d932](4b9d932)) * source controlling cfn templates that will be used for our release process ([#345](#345)) ([456dda0](456dda0)) * update dependabot to update mainline-1.x ([#440](#440)) ([960f3e5](960f3e5)) * update gh token ([#412](#412)) ([f8ada9b](f8ada9b)) * update release process ([#396](#396)) ([c0ff093](c0ff093)) * update releaserc to include pom.xml file ([#357](#357)) ([63e2f05](63e2f05)) * update token name and timeout ([#411](#411)) ([c0d5a0e](c0d5a0e)) * updating prod template to remove resources and abstract ones ([#354](#354)) ([ecc17a6](ecc17a6)) * Upgrade mockito to 4.0.0 ([#438](#438)) ([629dbfd](629dbfd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Uses the correct GH PAT in order to log in to github using the gh cli. gh cli is needed in order to create the release and upload the artifacts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: