-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node 16 LTS runtime #494
Conversation
@subinataws @leoherran-aws can we get this reviewed and merged? |
@jezhodges - Thanks for the contribution. Note that merging here is not going to reflect the changes in CodeBuild's offered images on AWS Cloud. Team picks up updates in batches and will queue this up for the next image update and needs to release a new fleet AMI to CodeBuild's fleet that has these Docker images, including any version updates, cached. |
On 2022-04-19 Node 18.0.0 was released, see eg. https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V18.md#18.0.0 I don't want to start maintaining our own container images for CodeBuild just to avoid lagging too far behind. :( |
Agreed. The speed at which they pull in the latest versions of runtimes is a joke. |
Lambda runtime for node 16 finally landed - codebuild still behind, so disappointing... https://aws.amazon.com/about-aws/whats-new/2022/05/aws-lambda-adds-support-node-js-16/ |
+1 |
@@ -203,8 +203,10 @@ RUN set -ex \ | |||
|
|||
ENV NODE_12_VERSION="12.22.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should drop Node version 12 because Active Support ended 1 year and 6 months ago
(20 Oct 2020) and Security Support ended 2 weeks and 3 days ago
(30 Apr 2022).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWS Lambda still supports Node.js 12 and it's not on the deprecation list. In any case: I think dropping Node 12 is out of scope for this PR.
Thanks for the contribution. Latest node.js LTS is supported in https://github.com/aws/aws-codebuild-docker-images/releases/tag/22.06.30 |
Issue: #490
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.