Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go minior releases #323

Closed
wants to merge 3 commits into from
Closed

Update Go minior releases #323

wants to merge 3 commits into from

Conversation

nc-wittj
Copy link

Issue #, if available:

Description of changes:
New minor versions of Go have been released (including security patches and bug fixes). This PR updates to the latest minor version for both the standard:3.0 and the standard:4.0 images.

For the standard:3.0 image:

  • 1.13.4 -> 1.13.9
  • 1.12.13 -> 1.12.17

For the standard:4.0 image:

  • 1.13.8 -> 1.13.9
  • 1.14.0 -> 1.14.1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Updates:
 - 1.13.4 -> 1.13.9
 - 1.12.13 -> 1.12.17
Updates:
 - 1.13.8 -> 1.13.9
 - 1.14.0 -> 1.14.1
@nc-wittj
Copy link
Author

Looks like we're blocked by go-nv/goenv#116 for the standard:4.0 image.

@syndbg
Copy link

syndbg commented Mar 21, 2020

Sorry, merged :)

@nc-wittj
Copy link
Author

Thanks, @syndbg! I think this PR should be good to go then! I seem to be able to build both containers locally.

@subinataws
Copy link
Contributor

Thanks for the contribution. We will pick this update in our next release.

@nc-wittj
Copy link
Author

nc-wittj commented May 6, 2020

@subinataws Thanks! This PR is now outdated. We should upgrade to Go 1.14.2 and Go 1.13.10.

@subinataws
Copy link
Contributor

subinataws commented May 6, 2020

Just to set expectations, our release starts from an internal version of the Dockerfile and we push that updated Dockerfile to this repo as the last step of the release. While you can update your PR here, note that isn't what necessarily get picked up internally. We have a release in flight which has 1.14.2 and 1.13.10 in it already. It'll take a few weeks to become user visible as it needs to roll out to all AWS Regions.

@nc-wittj
Copy link
Author

nc-wittj commented May 6, 2020

@srikanthataws Ah, thanks for the clarification! Should we keep this PR open if that's already in flight?

@subinataws
Copy link
Contributor

Resolving this. This update is in flight.

@subinataws subinataws closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants